[Webkit-unassigned] [Bug 237473] MediaTime::invalidTime() isn't convertible without loss into CMTime

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 4 07:56:59 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=237473

--- Comment #1 from Jean-Yves Avenard [:jya] <jean-yves.avenard at apple.com> ---
Actually, earlier description is incorrect:

the code of toCMTime is as follow:
```
    CMTime time;

    if (mediaTime.hasDoubleValue())
        time = CMTimeMakeWithSeconds(mediaTime.toDouble(), mediaTime.timeScale());
    else
        time = CMTimeMake(mediaTime.timeValue(), mediaTime.timeScale());

    if (mediaTime.isValid())
        time.flags |= kCMTimeFlags_Valid;
    if (mediaTime.hasBeenRounded())
        time.flags |= kCMTimeFlags_HasBeenRounded;
    if (mediaTime.isPositiveInfinite())
        time.flags |= kCMTimeFlags_PositiveInfinity;
    if (mediaTime.isNegativeInfinite())
        time.flags |= kCMTimeFlags_NegativeInfinity;

    return time;
```

what converting MediaTime::invalidTime() : `CMTimeMake(mediaTime.timeValue(), mediaTime.timeScale());` will return a valid time and that flag isn't reset.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220304/38f0cd84/attachment.htm>


More information about the webkit-unassigned mailing list