[Webkit-unassigned] [Bug 237329] [XCBuild] Emit a discovered dependency file from offlineasm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 3 12:11:11 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=237329

Elliott Williams <emw at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #453560|0                           |1
        is obsolete|                            |
 Attachment #453776|                            |review?
              Flags|                            |

--- Comment #14 from Elliott Williams <emw at apple.com> ---
Created attachment 453776

  --> https://bugs.webkit.org/attachment.cgi?id=453776&action=review

Integrate offlineasm using build rules and emit a depfile r6

Clarify boolean expression, fix multi-architecture builds, and keep generated file outputs in their old locations

This fixes the bug Alexey noticed, where LLIntAssembly.h is no longer in the build directory and its file reference in the Xcode project goes missing. It also reduces the surface area of this change, since the pbxbuild and xcbuild versions of this script always write to the same locations.

I mistakingly thought that offlineasm had to be run once per architecture -- in reality, it wants to run once and generate assembly for all active platforms at once. I have unchecked "Run once per architecture" in the build rules.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220303/1d848c8c/attachment.htm>


More information about the webkit-unassigned mailing list