[Webkit-unassigned] [Bug 237329] [XCBuild] Emit a discovered dependency file from offlineasm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237329

Keith Miller <keith_miller at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #453560|review?                     |review-
              Flags|                            |

--- Comment #8 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 453560
  --> https://bugs.webkit.org/attachment.cgi?id=453560
Integrate offlineasm using build rules and emit a depfile r5

View in context: https://bugs.webkit.org/attachment.cgi?id=453560&action=review

> Source/JavaScriptCore/offlineasm/asm.rb:391
> +if FileTest.exist?(outputFlnm) and not $options[:depfile] or FileTest.exist?($options[:depfile])

Can we put parens here that way it's trivial to remember if this is: `FileTest.exist?(outputFlnm) and (not $options[:depfile] or FileTest.exist?($options[:depfile]))` vs `(FileTest.exist?(outputFlnm) and not $options[:depfile]) or FileTest.exist?($options[:depfile])`. I also think it's wrong without the parens anyway (IIRC, this is the latter).

> Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:78
> +if FileTest.exist?(outputFlnm) and not $options[:depfile] or FileTest.exist?($options[:depfile])

Ditto.

> Source/JavaScriptCore/offlineasm/generate_settings_extractor.rb:60
> +if FileTest.exist?(outputFlnm) and not $options[:depfile] or FileTest.exist?($options[:depfile])

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220302/aed5e877/attachment.htm>