[Webkit-unassigned] [Bug 237329] [XCBuild] Emit a discovered dependency file from offlineasm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237329

--- Comment #6 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 453524
  --> https://bugs.webkit.org/attachment.cgi?id=453524
Integrate offlineasm using build rules and emit a depfile r2

View in context: https://bugs.webkit.org/attachment.cgi?id=453524&action=review

I'm gonna assume the JavaScriptCore.xcodeproj/project.pbxproj changes are correct since I don't know how to read that directly but everything else looks good.

> Source/JavaScriptCore/offlineasm/asm.rb:419
> +        sources = ast.flatten.reduce(Set.new) { |files, node| files.add(node.codeOrigin.fileName) }

Can you put a FIXME here to add files to a set when executing the import step and link to a bugzilla. I think that would be more efficient since there may be tens of thousands of nodes per file and offlineasm is somewhat slow already.

> Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:90
> +
> +

Can you remove this extra whitespace?

> Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:95
> +    sources = ast.flatten.reduce(Set.new) { |files, node| files.add(node.codeOrigin.fileName) }

Ditto on FIXME.

> Source/JavaScriptCore/offlineasm/generate_settings_extractor.rb:75
> +    sources = prunedAST.flatten.reduce(Set.new) { |files, node| files.add(node.codeOrigin.fileName) }

Ditto on FIXME.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220302/56b6503f/attachment-0001.htm>