[Webkit-unassigned] [Bug 242178] New: REGRESSION (250816 at main): composite option in Element.animate() is ignored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=242178

            Bug ID: 242178
           Summary: REGRESSION (250816 at main): composite option in
                    Element.animate() is ignored
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Animations
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: graouts at webkit.org
                CC: dino at apple.com, graouts at apple.com

We used to guard the `iterationComposite` property with the same runtime flag as the `composite` property. When we introduced a dedicated flag for the iterationComposite property (bug 240727) we mistakenly switched the guard in `KeyframeEffect::create()` which governed both properties from the `composite` guard to the `iterationComposite` guard, instead of adding the two guards, one for each property. As a result, the `composite` property can no longer be set via Element.animate() or the KeyframeEffect constructor.

This was found by WPT.fyi with the recent release of STP 148 which first introduced this change:

https://wpt.fyi/results/web-animations/animation-model/animation-types/accumulation-per-property-001.html?q=seq%28%28status%3Apass%7Cstatus%3Aok%29%20%28status%3Apass%7Cstatus%3Aok%29%20%28status%3A%21pass%26status%3A%21ok%26status%3A%21unknown%29%20%28status%3A%21pass%26status%3A%21ok%26status%3A%21unknown%29%29&run_id=6308426865967104&run_id=5702899928662016&run_id=5636710942638080&run_id=5070812443836416

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220630/7968e131/attachment.htm>