[Webkit-unassigned] [Bug 240517] [GTK] AX: AtspiCollection is not implemented on the document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=240517

--- Comment #7 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 460476
  --> https://bugs.webkit.org/attachment.cgi?id=460476
Patch

Patch logic looks fine, but there are a couple of build issues introduced:

FAILED: bin/TestWebKitAPI/TestWebCore 
: && /usr/bin/c++ -fdiagnostics-color=always -Wextra -Wall -pipe -Wno-odr -Wno-stringop-overread -Wno-stringop-overflow -Wno-nonnull -Wno-array-bounds -Wno-expansion-to-defined -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wcast-align -Wno-tautological-compare  -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -fuse-ld=lld -Wl,--disable-new-dtags @CMakeFiles/TestWebCore.rsp -o bin/TestWebKitAPI/TestWebCore  && :
ld.lld: error: undefined symbol: WebCore::AccessibilityObjectAtspi::s_collectionFunctions
>>> referenced by UnifiedSource-aba958d6-5.cpp
>>>               Source/WebCore/CMakeFiles/WebCore.dir/./__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-5.cpp.o:(WebCore::AccessibilityObjectAtspi::registerObject() (.part.0))

and this:

In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/Hasher.h:27,
                 from /app/webkit/Source/WebCore/platform/graphics/FloatPoint.h:31,
                 from /app/webkit/Source/WebCore/platform/graphics/FloatRect.h:29,
                 from /app/webkit/Source/WebCore/dom/ElementContext.h:29,
                 from /app/webkit/Source/WebCore/loader/FrameLoaderTypes.h:31,
                 from /app/webkit/Source/WebCore/loader/FrameLoaderClient.h:33,
                 from /app/webkit/Source/WebCore/accessibility/AccessibilityObjectInterface.h:30,
                 from /app/webkit/Source/WebCore/accessibility/AccessibilityObject.h:32,
                 from /app/webkit/Source/WebCore/accessibility/AccessibilityNodeObject.h:31,
                 from /app/webkit/Source/WebCore/accessibility/AccessibilityRenderObject.h:31,
                 from /app/webkit/Source/WebCore/accessibility/AccessibilityTree.h:32,
                 from /app/webkit/Source/WebCore/accessibility/AccessibilityTree.cpp:30,
                 from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-5.cpp:1:
/app/webkit/WebKitBuild/Release/WTF/Headers/wtf/URL.h:327:13: note: candidate: ‘bool WTF::operator==(const WTF::URL&, const WTF::URL&)’
  327 | inline bool operator==(const URL& a, const URL& b)
      |             ^~~~~~~~
/app/webkit/WebKitBuild/Release/WTF/Headers/wtf/URL.h:327:35: note:   no known conversion for argument 1 from ‘const WTF::String’ to ‘const WTF::URL&’
  327 | inline bool operator==(const URL& a, const URL& b)
      |                        ~~~~~~~~~~~^
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-5.cpp:7:
/app/webkit/Source/WebCore/accessibility/atspi/AccessibilityObjectCollectionAtspi.cpp:156:23: error: no match for ‘operator==’ (operand types are ‘const WTF::String’ and ‘const char [11]’)


There has been some commits lately removing a few implicit constructors and
conversions between URL and String. Maybe you'll want to setup a to clone from
the GitHub repository now that it's the canonical source of truth (pun intended :)

Also I assume we'll want this backported to the 2.36.x release branch, so I will
be listing it there tentativaly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220624/5f8c1b55/attachment.htm>