[Webkit-unassigned] [Bug 241850] New: REGRESSION(250984 at main): [Linux] DrmFourCCFormatToGLInternalFormat() change breaks framebuffer blitting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=241850

            Bug ID: 241850
           Summary: REGRESSION(250984 at main): [Linux]
                    DrmFourCCFormatToGLInternalFormat() change breaks
                    framebuffer blitting
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: ANGLE
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: zan at falconsigh.net
                CC: alex at igalia.com, dino at apple.com, kbr at google.com,
                    kkinnunen at apple.com

ANGLE update at 250984 at main brought in the following change:
36f5e6ce5 Vulkan: Fix DRM to GL format conversion
https://chromium-review.googlesource.com/c/angle/angle/+/3624139
https://chromium.googlesource.com/angle/angle/+/36f5e6ce550870261998b77987d01c4a4e34e620

An XRGB8888 DMABuf is used as output for ANGLE execution. DrmFourCCFormatToGLInternalFormat(), called from the DmaBufImageSiblingEGL constructor, now returns a gl::Format object for the GL_BGRX8_ANGLEX internal format.

This trips up the GL_BlitFramebufferANGLE() call, during the validation of attachments, with gl::Format::EquivalentForBlit() returning false for the read and draw attachments. Read attachment at that point has the GL_RGB8 sized internal format, but the draw attachment (with the DMABuf underneath) sticks to the GL_BGRX8_ANGLEX format.

EquivalentBlitInternalFormat() helper maps GL_RGBX8_ANGLE to GL_RGB8 -- possibly it should do the same for GL_BGRX8_ANGLEX.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220622/cdde4502/attachment-0001.htm>