[Webkit-unassigned] [Bug 233785] [GTK4] WebKitWebView::context-menu errors out on GTK4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233785

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #7 from Adrian Perez <aperez at igalia.com> ---
(In reply to Michael Catanzaro from comment #6)
> (In reply to Alexander Mikhaylenko from comment #5)
> > This one is tricky - since it differs between GTK3 and GTK4, we have to
> > split the signal and the vfunc between gtk3 and gtk4 somehow... This likely
> > involves reorganizing WebKitWebView.c/h completely.
> 
> It shouldn't require a huge reorg. Remember that we are first waiting for
> gi-docgen support to land. Then we can move the doc comments that need to
> differ between GTK3/GTK4/WPE out into separate files, while leaving the code
> in one place. With this plan, #if won't work for the doc comments, but it
> will work for the code. You can just leave a non-doc comment where the doc
> comment would normally be, pointing to the file that holds the real doc
> comments.
> 
> ...right?

Support for gi-docgen landed in #226662 a while ago, but we still need
to go over the documentation and make sure all works fine for GTK4 builds.
Now we should be closer to having this fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220612/61cf846f/attachment.htm>