[Webkit-unassigned] [Bug 241535] New: [Filters] LightSource should keep its points in logical units

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=241535

            Bug ID: 241535
           Summary: [Filters] LightSource should keep its points in
                    logical units
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Created attachment 460186

  --> https://bugs.webkit.org/attachment.cgi?id=460186&action=review

feSpecularLighting test case

Open the attached test cases.

Expected: A green circle and green ellipse should be drawn.

The problem is PointLightSource and SpotLightSource are created with points in user space coordinates. See SVGFEPointLightElement::lightSource() and SVGFESpotLightElement::lightSource(). But this requires knowing the filter targetBoundingBox and the primitiveUnits.

When dynamically updating these points through SVGFEDiffuseLightingElement::setFilterEffectAttribute() or SVGFESpecularLightingElement::setFilterEffectAttribute() the filter is not available and these points are set in logical coordinates. This means these points will have values between -1 and 1 in user space coordinates. This is why the green circle and ellipse are not shown in the test cases.

The fix is to make LightSource store their points in logical coordinates and to resolve them to user space coordinates in initPaintingData().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220612/bbfd1ce0/attachment.htm>