[Webkit-unassigned] [Bug 241516] -Wmismatched-new-delete warning spam from CSSStyleValue.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 10 11:39:12 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=241516

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org

--- Comment #1 from Michael Catanzaro <mcatanzaro at gnome.org> ---
I found a fix, but it makes no sense:

diff --git a/Source/WebCore/css/typedom/CSSStyleValue.h b/Source/WebCore/css/typedom/CSSStyleValue.h
index da615424d5c4..72f580a5facf 100644
--- a/Source/WebCore/css/typedom/CSSStyleValue.h
+++ b/Source/WebCore/css/typedom/CSSStyleValue.h
@@ -110,7 +110,10 @@ class CSSStyleValue : public RefCounted<CSSStyleValue>, public ScriptWrappable {
 public:
     String toString() const;
     virtual void serialize(StringBuilder&, OptionSet<SerializationArguments> = { }) const;
-    virtual ~CSSStyleValue() = default;
+    virtual ~CSSStyleValue()
+    {
+        m_customPropertyName = { };
+    }

     virtual CSSStyleValueType getType() const { return CSSStyleValueType::CSSStyleValue; }


If anybody knows a logical reason why this should make any difference....

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220610/554b04e0/attachment.htm>


More information about the webkit-unassigned mailing list