[Webkit-unassigned] [Bug 221260] [JSC] Enable WasmLLInt on ARMv7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 9 13:02:24 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=221260

--- Comment #39 from Mark Lam <mark.lam at apple.com> ---
(In reply to Geza Lore from comment #37)
> > Declaring a new OFFLINE_ASM_xxx can have a measurable impact on build times as it causes LLIntAssembly.h (or at least it used to the last time we measured this).
> 
> ... to what?

Sorry.  I meant that it causes the permutations in LLIntAssembly.h to double.  We previously observed that this increased compilation time noticeably.

On second thought, I may be wrong about the additional declaration increasing the permutations.  If it's not used in the .asm files, then maybe it won't increase the permutations.  But every newly used OFFLINE_ASM configuration value like this will effectively double the permutations in LLIntAssembly.h.

Regardless, it's not good to have an unused configuration option and it is also already implied by JSVALUE64 (which is already defined).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220609/1619658a/attachment.htm>


More information about the webkit-unassigned mailing list