[Webkit-unassigned] [Bug 221260] [JSC] Enable WasmLLInt on ARMv7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 9 12:43:35 PDT 2022


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
 Attachment #460126|review?                     |review+
              Flags|                            |

--- Comment #36 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 460126
  --> https://bugs.webkit.org/attachment.cgi?id=460126
v14 - fix wasm shared memory

View in context: https://bugs.webkit.org/attachment.cgi?id=460126&action=review

r=me with revert of unneeded change in LLIntOfflineAsmConfig.h.

> Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h:151
> +#if USE(JSVALUE32_64)
> +#define OFFLINE_ASM_JSVALUE32_64 1
> +#else
> +#define OFFLINE_ASM_JSVALUE32_64 0
> +#endif

Why is this needed?  Isn't this already inferred by the inverse of OFFLINE_ASM_JSVALUE64?  Your patch also doesn't use this.  Declaring a new OFFLINE_ASM_xxx can have a measurable impact on build times as it causes LLIntAssembly.h (or at least it used to the last time we measured this).  Let's not add a new one unless there's a good reason to.  Please remove this before landing.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220609/92321c71/attachment.htm>

More information about the webkit-unassigned mailing list