[Webkit-unassigned] [Bug 241426] New: WTF::CrossThreadCopierBase::copy() should use std::forward

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 8 10:52:52 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=241426

            Bug ID: 241426
           Summary: WTF::CrossThreadCopierBase::copy() should use
                    std::forward
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: cdumez at apple.com

WTF::CrossThreadCopierBase::copy() should use std::forward.

Found by clang static analyzer:

In file included from OpenSource/Source/WTF/wtf/Language.cpp:29:
OpenSource/Source/WTF/wtf/CrossThreadCopier.h:225:106: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
            return CrossThreadCopier<std::remove_const_t<std::remove_reference_t<decltype(type)>>>::copy(WTFMove(type));
                                                                                                         ^

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220608/d3bbe60e/attachment-0001.htm>


More information about the webkit-unassigned mailing list