[Webkit-unassigned] [Bug 241369] [JSC][ARMv7] Don't save CSRs respected by the JIT ABI on VM entry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 7 11:25:57 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=241369

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #460062|review?                     |review+
              Flags|                            |

--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 460062
  --> https://bugs.webkit.org/attachment.cgi?id=460062
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460062&action=review

r=me with comment fix up.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:776
> +    # but are not in RegisterSet::vmCalleeSaveRegisters() need to be saved here.
> +    # I.e.: Only those registers that are callee save in the C ABI, but are not
> +    # callee save in teh JIT ABI.

nit: "here. I.e.: Only" -> "here i.e. only".

/teh/the/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220607/3f359e2b/attachment.htm>


More information about the webkit-unassigned mailing list