[Webkit-unassigned] [Bug 221260] [JSC] Enable WasmLLInt on ARMv7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 7 07:13:00 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=221260

--- Comment #28 from Geza Lore <glore at igalia.com> ---
Comment on attachment 460061
  --> https://bugs.webkit.org/attachment.cgi?id=460061
v13 - ARM64E fix

View in context: https://bugs.webkit.org/attachment.cgi?id=460061&action=review

> Source/JavaScriptCore/wasm/WasmInstance.h:113
>          if (m_memory != nullptr) {
> -            m_cachedMemory = CagedPtr<Gigacage::Primitive, void, tagCagedPtr>(memory()->memory(), memory()->boundsCheckingSize());
> -            m_cachedBoundsCheckingSize = memory()->boundsCheckingSize();
> +            // This is used by the non-signaling based bound checking, so use the actual size of the memory.
> +            m_cachedBoundsCheckingSize = memory()->size();
> +            m_cachedMemory = CagedPtr<Gigacage::Primitive, void, tagCagedPtr>(memory()->memory(), m_cachedBoundsCheckingSize);
>              ASSERT(memory()->memory() == cachedMemory());
>          }

This is the only diff from the original reverted patch. (Now we tag m_cachedMemory with the same key as we use for untagging it)

> Tools/Scripts/run-jsc-stress-tests:1772
> +        if $isFTLPlatform

Also fixed this typo

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220607/eb6cdb46/attachment.htm>


More information about the webkit-unassigned mailing list