[Webkit-unassigned] [Bug 240945] `git-webkit pr` requires uncommitted changes to do any work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 15:47:00 PDT 2022


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #6 from Kenneth Russell <kbr at google.com> ---
At this point, `git-webkit pr --amend` will upload the same branch to an existing PR even if all changes have been committed.

One caveat is that if multiple commits are made on the branch, all of their commit messages seem to show up concatenated in the PR. For this reason, it seems the expected workflow is to use `git commit --amend` locally. Personally, I would prefer if commits were auto-squashed upon PR upload or amending, because this makes it easier to keep local branch history especially with long-running branches, but this is a matter of opinion.

Please do keep the documentation for git-webkit up to date; https://github.com/WebKit/WebKit/wiki/Pull-Requests is out of date now (it doesn't use eng/-prefixed branches any more, for example). Thanks.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220602/1bd651d3/attachment.htm>

More information about the webkit-unassigned mailing list