[Webkit-unassigned] [Bug 241208] [GitHub] Reconcile the top message of the PR with the git commit message

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 11:39:05 PDT 2022


--- Comment #4 from Myles C. Maxfield <mmaxfield at apple.com> ---
(In reply to Alexey Proskuryakov from comment #2)
> it just looks like the commit message doesn't follow our format

That's true. However, the top post in the PR thread _does_ follow our format.

> I don't think that automation should be able to re-format a sentence like
> this to a proper commit message.
> Not sure how the formatted commit message ended up in the top comment though.

The git commit message said this:

[WGSL] Adjust comment of test to match the tested source
The source code and comment seem to have detached from each other, where the comment retains an old syntax.

The top post in the PR said this:

[WGSL] Adjust comment of test to match the tested source

Reviewed by Myles C. Maxfield.

* WGSLUnitTests/WGSLLexerTests.mm

And yet we failed to merge. Which is a bit contributor-hostile - they've told us everything we need to know to merge. They've even formatted it correctly! It's just in place B rather than in place A. We seem to just be insisting that the information come from place A rather than place B.

We should allow the information to come from either place. The whole point of the move to GitHub is to make it easier for contributors to contribute. If a contributor goes through the trouble of formatting the entry but putting it in the top post in the PR instead of the commit message, we shouldn't punish them but should instead graciously accept the information they have given us - because they've given us all the information we need.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220602/d6722f76/attachment.htm>

More information about the webkit-unassigned mailing list