[Webkit-unassigned] [Bug 241420] [WPE][GTK] Drop _in_world variants of run_javascript APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=241420

Daniel Kolesa <dkolesa at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dkolesa at igalia.com

--- Comment #2 from Daniel Kolesa <dkolesa at igalia.com> ---
There is a caveat that I came across when debugging https://github.com/WebKit/WebKit/pull/1378. The PR seemingly assumes that empty string world name == NULL world name == default world. This is not the case, as the default world is completely isolated.

However, I believe we could reserve NULL input in the world parameter as a special case for the default world, and treat any non-NULL argument as a specific world name. That would enable the existing APIs to work (it effectively only loosens their behavior) while allowing to drop the others.

The API introduced in the PR also needs to be fixed. I will create a pull request to fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220726/0ea8a32f/attachment.htm>