[Webkit-unassigned] [Bug 242401] AX: Expose suggestion, insertion, deletion roles and attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=242401

--- Comment #13 from Joshua Hoffman <jhoffman23 at apple.com> ---
(In reply to Andres Gonzalez from comment #12)
> (In reply to Joshua Hoffman from comment #11)
> > Created attachment 460802 [details]
> > Patch

> --- a/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
> +++ a/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
> @@ -4025,6 +4036,11 @@ ALLOW_DEPRECATED_IMPLEMENTATIONS_END
>          }
>      }
> 
> +    if (backingObject->isTextControl() || backingObject->isStaticText()) {
> +        if ([attribute isEqualToString:(NSString
> *)kAXAttributedStringForRangeParameterizedAttribute])
> 
> Do we need to cast kAXAttributedStringForRangeParameterizedAttribute?
> 
> +            return [self doAXAttributedStringForRange:range];
> 
> Why we don't need to check for rangeSet as before?

On second thought, I will add the rangeSet check back in (especially in the context of the checks below it).

The cast prevents Xcode warnings, in addition to maintaining consistency (we cast CFStrings to NSStrings throughout WebKit).

> 
> --- a/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
> +++ a/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
> 
> Why we return NO in all the new methods on the Mac? If we don't need this on
> the Mac perhaps we should say notImplemented()?

Yeah, we don't need these implementations on the Mac. Good call-out about adding notImplemented—I will make that change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220712/f1723988/attachment.htm>