[Webkit-unassigned] [Bug 242554] New: Shall the workaround for llvm.37598 be removed?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=242554

            Bug ID: 242554
           Summary: Shall the workaround for llvm.37598 be removed?
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Enhancement
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: 674815634 at qq.com

I find a workaround for llvm.37598 in line 86 of mem.c:
https://github.com/WebKit/WebKit/blob/main/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/mem.c

// Windows doesn't really support weak symbols as of May 2019, and Clang on
// Windows will emit strong symbols instead. See
// https://bugs.llvm.org/show_bug.cgi?id=37598
#if defined(__ELF__) && defined(__GNUC__)
#define WEAK_SYMBOL_FUNC(rettype, name, args) \
  rettype name args __attribute__((weak));
#else
#define WEAK_SYMBOL_FUNC(rettype, name, args) static rettype(*name) args = NULL;
#endif

This compiler bug is already fixed: https://bugs.llvm.org/show_bug.cgi?id=37598
Shall these workarounds be removed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220709/c362aead/attachment.htm>