[Webkit-unassigned] [Bug 242269] New: Address review feedback in https://github.com/WebKit/WebKit/pull/1928

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=242269

            Bug ID: 242269
           Summary: Address review feedback in
                    https://github.com/WebKit/WebKit/pull/1928
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: pvollan at apple.com

Address review feedback in https://github.com/WebKit/WebKit/pull/1928:

This function WebPageProxy::iconForAttachment is confusing.

1) 'imageAndSize' and 'image' should be renamed to 'iconAndSize' and 'icon' since the type is IconAndSize and the data member is .icon.

2) 'size' should be part of the return value. It's super subtle that 'size' is an out parameter -- but only on one platform!

3) Look into creating an API test for this

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220701/c824fe18/attachment-0001.htm>