[Webkit-unassigned] [Bug 242258] New: [Make] Recognize feature flags in BUILD_WEBKIT_OPTIONS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 1 12:01:12 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=242258

            Bug ID: 242258
           Summary: [Make] Recognize feature flags in BUILD_WEBKIT_OPTIONS
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: emw at apple.com

build-webkit recognizes features defined in FeatureList.pm and passes corresponding build settings to Xcode. Make, despite having a BUILD_WEBKIT_OPTIONS setting for developers to override, does not parse out feature flag arguments. As a result, if you want to pass a feature flag to Make, you have to know what the corresponding build setting is. You also need to know that build-webkit defines the build setting as own name (i.e. ENABLE_PDFJS=ENABLE_PDFJS) and not YES.

We should fix this so that

    build-webkit --debug --pdfjs

and

    make debug BUILD_WEBKIT_OPTIONS=--pdfjs

pass the same settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220701/b7a1ad9c/attachment.htm>


More information about the webkit-unassigned mailing list