[Webkit-unassigned] [Bug 241920] canPlayType and video codec filtering fail for VP8 on Mac with VP8 but not VP9 hardware codecs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 1 10:58:43 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=241920

--- Comment #23 from Eric Carlson <eric.carlson at apple.com> ---
> I have no insight into the substance of the fix, someone else would need to comment about that.

The code change looks good to me, although it would be nice to have a test. 

A WebKit layout test can enable and disable the VP9 HW decoder with `internals.setHardwareVP9DecoderDisabledForTesting` to , see LayoutTests/platform/mac/media/mediacapabilities/vp9-decodingInfo-sw.html for example. This could be used to disable the HW decoder and exercise your logic.

If you don't have time to create a test we will pick up your work and create a full PR in the next week or so.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220701/d846cf7e/attachment.htm>


More information about the webkit-unassigned mailing list