[Webkit-unassigned] [Bug 242156] REGRESSION(243836 at main): [GStreamer] Broke videos in yelp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=242156

Philippe Normand <philn at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philn at igalia.com

--- Comment #3 from Philippe Normand <philn at igalia.com> ---
"""
Drive-by fix: to allow this change to be testable, we must revert a change which calls all the
network delegate callbacks with empty data. This was necessary at the time because (at least for
Cocoa ports) media loading happened outside WebCore's loader path. Currently, all http(s), data,
blob, and custom protocol schemes are loaded through WebCore, leaving file:// URLs as the
remaining protocol type that needs custom handling, and only on Cocoa ports.
"""

Well, IIUC, GStreamer ports also apply here, file loading doesn't go through WebCore, but with a pure-GStreamer filesrc element.

Can you try this test?

if ((!url.isEmpty() || url.isLocalFile()) && !frame->loader().willLoadMediaElementURL(url, *this)) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220701/620ffd42/attachment.htm>