[Webkit-unassigned] [Bug 235686] Generate compile_commands.json on macOS Builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 09:29:42 PST 2022


--- Comment #13 from Saam Barati <sbarati at apple.com> ---
(In reply to Alexey Proskuryakov from comment #12)
> This should probably be added to DebugRelease.xcconfig, not to
> Base.xcconfig, to avoid unnecessarily changing production builds.
Yeah, definitely. I was wrong to say Base.xcconfig at first. I talked to Brandon on slack and we decided on putting it inside DebugRelease to avoid generating during production builds.

That said, I think Brandon might go with an approach where it's just put inside LocalOverrides.xcconfig and then it can be opt in via that.

> Putting the directory to the root of WebKitBuild is also not great because
> it's a location shared between all build styles and platforms - there is a
> reason why everything goes into subdirectories like Release-iphonesimulator
> there. But can clangd deal with switching between build styles?
> I found a guide using cdb where it's recommended to disable precompiled
> headers to make it work better,
> <https://www.barebones.com/support/bbedit/lsp-notes.html#caveats>. This of
> course would be unacceptable to do when generating it as part of normal
> builds. Plus there are some other flags which I'm not sure if they change
> anything for WebKit. How bad is the impact of generating cdb with
> precompiled headers?
> > If we do decide to do it by default, I think we should measure impact on compile time first.
> Agreed.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220131/c691545f/attachment.htm>

More information about the webkit-unassigned mailing list