[Webkit-unassigned] [Bug 230845] Remove Node::deprecatedIsInert

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230845

--- Comment #3 from Tim Nguyen (:ntim) <ntim at apple.com> ---
(In reply to Ryosuke Niwa from comment #2)
> yeah, I don't think we should do this. This would require that
> Element::isFocusable() to rely on the latest style information. That's not
> tenable given this function needs to be fast and avoid style recalc.
> 
> I really don't think we should have designed the concept of inert to rely on
> style resolution at all.

The idea is to re-use isVisibleWithoutResolvingFullStyle (used by isFocusable), which does not resolve the full style. The problem is that the style is not invalidated correctly in some cases.

https://webkit-search.igalia.com/webkit/rev/fb57dd12e0db42483fce7f5e75a2e4ab66ae11a9/Source/WebCore/dom/Element.cpp#3553

So we already consult the style right now in Element::isFocusable for display/visibility, this would just add effectiveInert in it. I don't think this would be slower, since the style is already consulted for those 2 properties anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220130/fa3b2091/attachment.htm>