[Webkit-unassigned] [Bug 235744] [XCBuild] WTF's headers are copied via a script and are invisible to the build system

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 29 17:29:55 PST 2022


--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 450301
  --> https://bugs.webkit.org/attachment.cgi?id=450301
Add native file references for Scripts/

View in context: https://bugs.webkit.org/attachment.cgi?id=450301&action=review

> we can tell Xcode to copy the whole directory and its contents

Seems a little surprising if Xcode does proper dependency tracking for each file in this case, even though they are in not mentioned in the project individually. Is there a way to confirm that it does?

> This approach is obtuse. But as far as I can tell, the best way to get what we need (native PbxCp tasks for each header) is to create one copy files build phase per header subdirectory.

Indeed. Can you post radar numbers (without other details) of what will let us make it more elegant in the future?

What will WebKit engineers need to know about this approach when adding or removing WTF headers?

I wonder if flattening the hierarchy would be a better solution for now. That would require webkit-dev discussion if proposed, I think.

> Source/WTF/WTF.xcodeproj/project.pbxproj:162
> +		DD3DC85E27A4BF8E007E5B61 /* WeakHashSet.h in Headers */ = {isa = PBXBuildFile; fileRef = 9B67F3F12228D5310030DE9C /* WeakHashSet.h */; settings = {ATTRIBUTES = (Public, ); }; };

Nothing in WTF is public API, is it OK for these headers to have the Public attribute?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220130/3b658ad7/attachment.htm>

More information about the webkit-unassigned mailing list