[Webkit-unassigned] [Bug 235751] [XCBuild] Add headers-only dependencies to projects in Tools/

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235751

--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 450253
  --> https://bugs.webkit.org/attachment.cgi?id=450253
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450253&action=review

>These variables control the "Headers" directory that Xcode's build phases can copy into [1]. 

I still don't quite understand. The project now specifies the path in copy phases with this:

dstPath = "$(PRIVATE_HEADERS_FOLDER_PATH)/internal";

Is there some other effect that's implicit?

> Source/ThirdParty/gtest/xcode/Config/StaticLibraryTarget.xcconfig:11
> +PUBLIC_HEADERS_FOLDER_PATH = /usr/local/include/gtest
> +PRIVATE_HEADERS_FOLDER_PATH = /usr/local/include/gtest

Perhaps we don't care for gtest, or this is necessary to work around other peculiarities in this project, but normally the former is /usr/include, and the latter is /usr/local/include.

> Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj:209
> +			dstPath = "$(PRIVATE_HEADERS_FOLDER_PATH)/internal";

It smells strange that "internal" headers need to be copied into any kind of "SDK" for other projects to use.

> Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj:515
> +		DD0EDF6F2798A073005152AD /* Headers */ = {

Perhaps this is where the implicit effect that I'm asking about is, this phase doesn't have dstPath.

> Tools/DumpRenderTree/mac/Configurations/Base.xcconfig:125
> +EXCLUDED_SOURCE_FILE_NAMES = $(EXCLUDED_PRODUCT_DEPENDENCY_NAMES_$(WK_WHICH_BUILD_SYSTEM));
> +EXCLUDED_PRODUCT_DEPENDENCY_NAMES_legacy = WebKit.framework;

This is inherited in DumpRenderTreeLibrary.xcconfig, but I'm not sure about other xcconfigs:

DumpRenderTree.xcconfig, DumpRenderTreeApp.xcconfig and TestNetscapePlugIn.xcconfig have EXCLUDED_SOURCE_FILE_NAMES too, although conditional by SDK. Do they overwrite this? Ot does it not matter for some reason?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220130/f2f8a722/attachment.htm>