[Webkit-unassigned] [Bug 235751] [XCBuild] Add headers-only dependencies to projects in Tools/

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235751

--- Comment #5 from Elliott Williams <emw at apple.com> ---
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 450199 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450199&action=review
> 
> > Source/ThirdParty/gtest/xcode/Config/StaticLibraryTarget.xcconfig:12
> > +// Copy headers into /usr/local/include/gtest
> > +PUBLIC_HEADERS_FOLDER_PATH = $(inherited)/gtest
> > +PRIVATE_HEADERS_FOLDER_PATH = $(inherited)/gtest
> 
> Searching for _HEADERS_FOLDER_PATH in existing xcconfigs, it looks like we
> tend to do it slightly differently, without $inherited. We also always have
> a prefix - which maybe doesn't matter because we don't build gtest in
> production builds, but then I don't understand why these are the correct
> variables to use. If they don't affect anything in Xcode, and are only used
> by the project to set script phase dstPath, would it be more elegant to
> define our own variables?

These variables control the "Headers" directory that Xcode's build phases can copy into [1]. For static libraries, this defaults to /usr/local/include. Looking at our other uses, I think it's clearer to spell out the full path. Fixed in the latest patch.

> > Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:33
> > +EXCLUDED_SOURCE_FILE_NAMES = $(EXCLUDED_SOURCE_FILE_NAMES_$(WK_COCOA_TOUCH)) $(EXCLUDED_PRODUCT_DEPENDENCY_NAMES_$(WK_WHICH_BUILD_SYSTEM));
> 
> We don't need this in other xcconfigs in this directory?
> 
> Can this use $(inherited)?

Looks like this is redundantly defined, fixed in the latest patch.

> 
> > Tools/TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig:30
> > +EXCLUDED_SOURCE_FILE_NAMES = $(EXCLUDED_PRODUCT_DEPENDENCY_NAMES_$(WK_WHICH_BUILD_SYSTEM));
> 
> This overwrites EXCLUDED_SOURCE_FILE_NAMES from Base.xconfig AFAICT.

Good catch, it needed an $(inherited). Fixed.


[1]: https://help.apple.com/xcode/mac/11.4/#/itcaec37c2a6?sub=devdbb795497

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220128/93edcf55/attachment-0001.htm>