[Webkit-unassigned] [Bug 235686] Generate compile_commands.json on macOS Builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235686

--- Comment #6 from Saam Barati <sbarati at apple.com> ---
(In reply to Elliott Williams from comment #4)
> Comment on attachment 450103 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450103&action=review
> 
> +1 to moving all settings to xcconfigs. JavaScriptCore.xcconfig should be
> the one you need.

We don't want Base.xcconfig so it's picked up by all targets?

> 
> > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:12765
> > +					"-isystem",
> > +					"$(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders",
> 
> I think this include is redundant. JSC already sets it in
> Source/JavaScriptCore/Configurations/Base.xcconfig, so it should get picked
> up by `$(inherited)`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220128/c8b17f76/attachment-0001.htm>