[Webkit-unassigned] [Bug 235701] [WPE][a11y] Add option to build with ATSPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 04:50:41 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=235701

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #450119|review?                     |review+
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 450119
  --> https://bugs.webkit.org/attachment.cgi?id=450119
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450119&action=review

> Source/WebCore/PlatformWPE.cmake:127
> +    )

IIRC we have a similar (if not the same) custom command in PlatformGTK.cmake;
it would be nice to factor out this functionality in a CMake function at some
point. Could be a follow up patch later on.

> Source/cmake/OptionsWPE.cmake:90
> +WEBKIT_OPTION_DEFINE(USE_ATSPI "Whether to use the Atspi a11y implementation instead of ATK." PRIVATE OFF)

Typo: Atspi → ATSPI

(All caps because it is an acronym, wasn't it?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220127/96921601/attachment-0001.htm>


More information about the webkit-unassigned mailing list