[Webkit-unassigned] [Bug 235663] Generated xcfilelists contain symlinks when building for macOS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 26 19:05:47 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=235663

--- Comment #6 from Elliott Williams <emw at apple.com> ---
(In reply to Alexey Proskuryakov from comment #5)
> I wonder if it would make more sense to name this
> WK_CONTENT_PATH_IN_FRAMEWORK or something.
> 
> Also, if you make it "Versions/A/" then you can avoid having "//" in paths
> in the embedded case.

Bikeshedding, but would you be ok with WK_FRAMEWORK_VERSION_PREFIX? If I implement the latter suggestion, we end up with declarations like

    INSTALL_PATH = $(WEBKIT_FRAMEWORKS_DIR)/WebKit.framework/$(WK_FRAMEWORK_VERSION_PREFIX)XPCServices

and I feel like "prefix" reassures that we aren't missing a path separator there :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220127/7419063e/attachment-0001.htm>


More information about the webkit-unassigned mailing list