[Webkit-unassigned] [Bug 235444] [GTK][STABLE] More missing headers and preprocessor guards for non-unified 2.34.4 build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235444

--- Comment #5 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Dennis from comment #2)
> What's the point of having those ENABLE preprocessor guards if they don't
> work? 

They're for other WebKit ports, and in cross-platform code they do need to be maintained.

In platform-specific code, they are just clutter.

> I don't know what "EWS" means, and I assumed that having this patch reviewed
> was implied.

Sorry, EWS is the CI system that builds your patch (scroll up a bit). Your previous patch was red on every single bot, indicating that the patch doesn't apply to trunk. They need to be at least mostly green (it's OK if bots are failing as long as the failure looks unrelated to your work).

You still need to set the r? Bugzilla flag to request a review. And again, if you don't follow my previous instructions to include changelog entries, it will be rejected.

> Guys, I spent many hours hunting down these bugs. And sooo many more waiting
> for it to compile -- *it takes well over 24 hours of non-stop 100% cpu time
> here to compile this!*.

Wow, that's... pretty intense.

> Can you guys do the final commit or whatever is needed?

No, sorry.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220123/ef707607/attachment-0001.htm>