[Webkit-unassigned] [Bug 235444] [GTK][STABLE] More missing headers for non-unified 2.34.3 build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235444

Dennis <dennisn at dennisn.mooo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #449665|0                           |1
        is obsolete|                            |

--- Comment #2 from Dennis <dennisn at dennisn.mooo.com> ---
Created attachment 449763

  --> https://bugs.webkit.org/attachment.cgi?id=449763&action=review

missing headers and if preprocessor guards against 2.34.4

Attached are the updated patches against stable 2.34.4. It includes the previous one that I submitted bug 235273 (I'll close it), plus one more missing header (Frame.h in Source/WebCore/inspector/agents/InspectorCanvasAgent.h).

What's the point of having those ENABLE preprocessor guards if they don't work? It won't compile if they're used -- might as well get rid of them then? And many of them sound very useful to be configurable, like ENABLE_GEOLOCATION ENABLE_ACCESSIBILITY ENABLE_VIDEO, etc.

I don't know what "EWS" means, and I assumed that having this patch reviewed was implied.

I fixed the indentation (the tab instead of the spaces), woops.

Guys, I spent many hours hunting down these bugs. And sooo many more waiting for it to compile -- *it takes well over 24 hours of non-stop 100% cpu time here to compile this!*. Can you guys do the final commit or whatever is needed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220123/22244da3/attachment.htm>