[Webkit-unassigned] [Bug 235477] New: What's going on with LTO_MODE?
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 22 06:37:09 PST 2022
https://bugs.webkit.org/show_bug.cgi?id=235477
Bug ID: 235477
Summary: What's going on with LTO_MODE?
Product: WebKit
Version: WebKit Nightly Build
Hardware: PC
OS: Linux
Status: NEW
Severity: Normal
Priority: P2
Component: CMake
Assignee: webkit-unassigned at lists.webkit.org
Reporter: mcatanzaro at gnome.org
CC: bugs-noreply at webkitgtk.org
I notice there is an LTO_MODE CMake variable that causes ld.lld to be selected in OptionsCommon.cmake, but this makes me nervous because I don't think anything ever sets LTO_MODE. It's not a public variable, either. How is it supposed to be used?
It adds its own manual -flto=${LTO_MODE} flags that would surely be redundant with the -flto=auto flags that are already used by distros that enable LTO. We might want to think about how this is supposed to work. I suppose it's OK so long as (a) nothing sets it except the end user, and (b) nothing assumes that it can be used to determine whether LTO is actually enabled. But assuming that LTO_MODE=OFF means no LTO seems very tempting. Maybe we could rename it to something like ADD_WEBKIT_LTO_FLAGS to be more clear that it's not the only way that LTO gets enabled?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220122/450fe54b/attachment.htm>
More information about the webkit-unassigned
mailing list