[Webkit-unassigned] [Bug 235465] New: MediaPlayerPrivateRemote::play() and MediaPlayerPrivateRemote::pause() modify m_cachedState.paused
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 21 18:42:38 PST 2022
https://bugs.webkit.org/show_bug.cgi?id=235465
Bug ID: 235465
Summary: MediaPlayerPrivateRemote::play() and
MediaPlayerPrivateRemote::pause() modify
m_cachedState.paused
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Media
Assignee: webkit-unassigned at lists.webkit.org
Reporter: peng.liu6 at apple.com
The following change is desired, but it will lead to a test timeout. (media/track/track-cues-pause-on-exit.html)
diff --git a/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp b/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
index 9a6429437842f43db6da1c25011ed4a544cbf361..cd1c9eaa70f47ecb7cf09b69c8c0bbdd00f29f43 100644
--- a/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
+++ b/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
@@ -227,13 +227,11 @@ void MediaPlayerPrivateRemote::prepareToPlay()
void MediaPlayerPrivateRemote::play()
{
- m_cachedState.paused = false;
connection().send(Messages::RemoteMediaPlayerProxy::Play(), m_id);
}
void MediaPlayerPrivateRemote::pause()
{
- m_cachedState.paused = true;
auto now = MonotonicTime::now();
m_cachedMediaTime += MediaTime::createWithDouble(m_rate * (now - m_cachedMediaTimeQueryTime).value());
m_cachedMediaTimeQueryTime = now;
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220122/ad83f3ce/attachment.htm>
More information about the webkit-unassigned
mailing list