[Webkit-unassigned] [Bug 234155] [Shadow Realms] Use WebCore module loaders for shadow realm importValue
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 21 13:08:33 PST 2022
https://bugs.webkit.org/show_bug.cgi?id=234155
--- Comment #24 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 449690
--> https://bugs.webkit.org/attachment.cgi?id=449690
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=449690&action=review
> Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:597
> + // Same-origin iframes present a difficult circumstance because the
> + // shadow realm global object cannot retain the incubating realm's
> + // global object (that would be a refcount loop); but, same-origioriginalWorld);
> + // iframes can create objects that outlive their global object.
> + //
> + // Our solution is to walk up the parent tree of documents as far as
> + // possible while still staying in the same origin to insure we don't
> + // allow the ShadowRealm to fetch modules masquerading as the wrong
> + // origin while avoiding any lifetime issues (since the topmost document
> + // with a given wrapper world should outlive other objects in that
> + // world)
Sounds good to me.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220121/cb16f49e/attachment-0001.htm>
More information about the webkit-unassigned
mailing list