[Webkit-unassigned] [Bug 235174] Setting undefined to video.playbackRate causes Safari to crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 08:38:00 PST 2022


--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 449567
  --> https://bugs.webkit.org/attachment.cgi?id=449567

View in context: https://bugs.webkit.org/attachment.cgi?id=449567&action=review

> Source/WebCore/ChangeLog:5
> +	rdar://problem/87815745

Nit: You have a tab here.

> Source/WebCore/html/HTMLMediaElement.cpp:3498
> +    if (!isfinite(rate))
> +        return;
> +

The spec defines `defaultPlaybackRate` and `playbackRate` as `double`:

  attribute double defaultPlaybackRate;
  attribute double playbackRate;

but HTMLMediaElement.idl uses `unrestricted double`:

    attribute unrestricted double defaultPlaybackRate;
    attribute unrestricted double playbackRate;

I wonder if the changes to setDefaultPlaybackRate and setPlaybackRate would be unnecessary if this was fixed?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220120/98493e09/attachment.htm>

More information about the webkit-unassigned mailing list