[Webkit-unassigned] [Bug 234578] Grid may be empty in certain scenarios

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234578

--- Comment #9 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 449536
  --> https://bugs.webkit.org/attachment.cgi?id=449536
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449536&action=review

It's unfortunate that we need to add an extra loop to the layout phase which could potentially worsen the performance. I'd like to know about the weird interaction between setting the height and clearing the overriding sizes before approving this.

> Source/WebCore/rendering/RenderGrid.cpp:179
> +void RenderGrid::clearChildrenOverridingLogicialHeight()

Logicial -> Logical

> Source/WebCore/rendering/RenderGrid.cpp:182
> +    // The clearOverridingLogicalHeight() affects the behavior of resetLogicalHeightBeforeLayoutIfNeeded().

That seems weird. The resetLogical... only sets the height to 0. How that could interact with clearing the overriding sizes is not clear to me...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220120/108cedbb/attachment.htm>