[Webkit-unassigned] [Bug 235385] [XCBuild] Build via the workspace with USE_WORKSPACE=YES

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235385

--- Comment #3 from Elliott Williams <emw at apple.com> ---
Comment on attachment 449529
  --> https://bugs.webkit.org/attachment.cgi?id=449529
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449529&action=review

FWIW, there are some known edge cases in our Makefile logic that I'd like to address outside ths patch. For example, WebInspectorUI only builds for Mac _or_ installsrc, and the workspace schemes do not accurately model that logic.

> Makefile.shared:-49
> -ifeq ($(findstring UseNewBuildSystem,$(ARGS)),)
> -	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')
> -	ifeq ($(CAN_USE_XCBUILD),1)
> -		# Temporarily disable default use of XCBuild until issues with it are ironed out.
> -		#XCODE_OPTIONS += -UseNewBuildSystem=YES
> -		XCODE_OPTIONS += -UseNewBuildSystem=NO
> -	else
> -		XCODE_OPTIONS += -UseNewBuildSystem=NO
> -	endif
> -endif
> -

Removed because we don't need it. *All* non-workspace builds with use the legacy build system, as they currently do, and this flag's behavior changed in rdar://86872452.

> WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:-6
> -	<key>BuildSystemType</key>
> -	<string>Original</string>

This only affects builds started from the workspace, so EWS + WebKit devs should continue to see PBXBuild for the time being.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220120/f0a50be2/attachment-0001.htm>