[Webkit-unassigned] [Bug 235376] New: CoreImage filters are enabled by the wrong setting
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 19 12:48:30 PST 2022
https://bugs.webkit.org/show_bug.cgi?id=235376
Bug ID: 235376
Summary: CoreImage filters are enabled by the wrong setting
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Layout and Rendering
Assignee: webkit-unassigned at lists.webkit.org
Reporter: sabouhallawa at apple.com
CC: bfulgham at webkit.org, simon.fraser at apple.com,
zalan at apple.com
There has been a confusion about how CoreImage filters can be enabled. There are two settings/feature controls which have been used:
1. CoreImageAcceleratedFilterRenderEnabled
2. AcceleratedFiltersEnabled
The first was used to enable CoreImage filters which also requires to have accelerated filters. It is also linked with the mini-browser experimental feature "CoreImage-Accelerated Filter Rendering". The use of it was mistakenly dropped in r286193 and AcceleratedFiltersEnabled has been used since then.
The second one was introduced by r102088 for the Chromium port back in 2011. There is nothing in WebKit enables this setting right now. And for Apple ports, I do not think there is any current plans for using IOSurfaces for software filters.
So I think to use the correct setting for enabling the CoreImage filters and to clean this area we need to do the following:
1. Delete the setting AcceleratedFiltersEnabled
2. Use CoreImageAcceleratedFilterRenderEnabled to enable CoreImage filters and to force using IOSurfaces for the intermediate filter images. This setting will be respected only if the filter chain can be rendered via CoreImage.
3. Fix the GTK unused parameter warning from FEColorMatrix::createApplier(), FEComponentTransfer::createApplier() and SourceGraphic::createApplier().
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220119/8a90f5fc/attachment-0001.htm>
More information about the webkit-unassigned
mailing list