[Webkit-unassigned] [Bug 235374] New: ValidatePatch shouldn't fetch the same PR information twice

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 12:36:54 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=235374

            Bug ID: 235374
           Summary: ValidatePatch shouldn't fetch the same PR information
                    twice
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aakash_jain at apple.com

ValidatePatch shouldn't fetch the same PR information twice. Currently it is fetching same information twice, both _is_pr_closed() and _is_pr_obsolete() methods call get_pr_json() which does network call to github to fetch PR information. Two calls to same url can be seen in https://ews-build.webkit-uat.org/#/builders/1/builds/1694/steps/3/logs/stdio
This code was added recently in https://commits.webkit.org/246047@main (https://github.com/WebKit/WebKit/pull/62).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220119/8ca2e8bd/attachment.htm>


More information about the webkit-unassigned mailing list