[Webkit-unassigned] [Bug 234578] Grid may be empty in certain scenarios

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234578

--- Comment #6 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 449432
  --> https://bugs.webkit.org/attachment.cgi?id=449432
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449432&action=review

There is one test failing. Check it out.

> Source/WebCore/rendering/RenderGrid.cpp:178
>  

Perhaps add a comment here explaining that this must be run after calling updateLogicalWidth() otherwise the shouldSkipChild() won't properly work. It'd be better to have an ASSERT for it, but I don't think it'd be easy to come up with any.

> Source/WebCore/rendering/RenderGrid.cpp:179
> +void RenderGrid::computeAspectRatioDependantAndBaselineItems(Vector<RenderBox*> &aspectRatioBlockSizeDependentGridItems)

Nit: the & should be placed right next to the type not the variable name

> Source/WebCore/rendering/RenderGrid.h:194
> +    void computeAspectRatioDependantAndBaselineItems(Vector<RenderBox*> &aspectRatioBlockSizeDependentGridItems);

Nit: the & should be right next to the type.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220119/46d77c08/attachment.htm>