[Webkit-unassigned] [Bug 235343] New: AX: Remove unnecessary isolated tree update for AXSelectedTextChanged node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235343

            Bug ID: 235343
           Summary: AX: Remove unnecessary isolated tree update for
                    AXSelectedTextChanged node
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: tyler_w at apple.com
                CC: andresg_22 at apple.com,
                    webkit-bug-importer at group.apple.com

When we get an AXSelectedTextChanged notification, we update the isolated tree with the node that has gained selection. Sometimes this node is not a part of the AX tree, meaning its AXAncestorFlags are not initialized. This results in hitting this ASSERT in AXIsolatedObject::initializeAttributeData:

// For all objects besides the root, the ancestry flags should've been set by now.
ASSERT(isRoot || object.ancestorFlagsAreInitialized());

I don't think updating the isolated tree with this node is necessary. This behavior was added here to fix accessibility/mac/search-text/search-text.html:

https://bugs.webkit.org/show_bug.cgi?id=208434

But the test passes in ITM with and without updating the isolated tree with this node.

Also, for text selection related operations, isolated tree objects currently defer to the main thread (e.g. AXIsolatedObject::selectedText, AXIsolatedObject::selectedText), further leading me to believe this update is unnecessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220119/208d7236/attachment-0001.htm>