[Webkit-unassigned] [Bug 235281] REGRESSION (r286603): rx::ProgramMtl::getSpecializedShader() leaks MTLFunctionConstantValues object due early return when an error occurs in ANGLE_TRY() macro

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 16 14:18:20 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=235281

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |229128

--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
(In reply to David Kilzer (:ddkilzer) from comment #0)
> Regressed with this commit:
> 
>     Roll ANGLE to include upstreamed Metal backend
>     <https://bugs.webkit.org/show_bug.cgi?id=220896>
>     <rdar://problem/73539682>
>     <https://commits.webkit.org/r286603>

Huh, that commit actually reverted some changes I made in r281160 to fix this leak earlier!

    [Metal ANGLE] Fix over-autorelease of rx::DisplayMtl::getMetalDeviceMatchingAttribute() and various Objective-C leak
s
    <https://webkit.org/b/229128>
    <rdar://problem/81964007>
    <https://commits.webkit.org/r281160>


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=229128
[Bug 229128] [Metal ANGLE] Fix over-autorelease of rx::DisplayMtl::getMetalDeviceMatchingAttribute() and various Objective-C leaks
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220116/032b716d/attachment.htm>


More information about the webkit-unassigned mailing list