[Webkit-unassigned] [Bug 234737] [GTK][a11y] Web process crashes in some sites having SVG images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234737

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 448066
  --> https://bugs.webkit.org/attachment.cgi?id=448066
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448066&action=review

> Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:35
> +static AccessibilityAtspi* s_currentAtspi;

This smells like we may want to use “NeverDestroyed<AccessibilityAtspi>“ and provide instead a
“::singleton()“ method. As far as I find from the code, only the WebProcess will have an instance
(and only one) of this, which gets created in “WebProcess::platformInitializeWebProcess()”. Then
we could ditch the “WebProcess::m_accessibility” member and the “WebProcess::accessibilityAtspi()“
accessor — then “WebPageGtk.cpp“ can use “AccessibilityAtspi::singleton()”, and that seems the
only place where the accessor is ever used.

Of course we would still something like an “AccessibilityAtspi::initialize(const String& busAddress)”
static method to configure the single instance from “::platformInitializeWebProcess()”.

Thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220110/baa96260/attachment-0001.htm>