[Webkit-unassigned] [Bug 234116] [WebAssembly][Modules] Unify memory import handling code in both module loader and JS cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 9 20:58:08 PST 2022


--- Comment #16 from Yusuke Suzuki <ysuzuki at apple.com> ---
(In reply to Asumu Takikawa from comment #13)
> I've rebased the patch for recent changes.
> > Yeah, I would like to know why this condition happens. And I think, if CalleeGroup is already created, then destroying it and replacing it sounds dangerous. Probably, initialize it with the other CalleeGroup's LLIntCallees would be better, but I first would like to know when this happens.
> I believe it might happen if the CalleeGroup came from a module that has
> already been used for another instance, but an OOM or similar event caused
> the compilation to fail there.
> In the current patch, I removed the second part of the condition so that it
> doesn't try to replace the CalleeGroup. In the case where the callee group
> is present but not runnable, it should try to re-compile the code in the
> existing code path in WebAssemblyModuleRecord.cpp around line 430 where it
> checks if the callee group is runnable. Does that seem better?

Sounds good to me!

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220110/7052cb8d/attachment.htm>

More information about the webkit-unassigned mailing list