[Webkit-unassigned] [Bug 234989] New: WebKit::nsTextAlignmentFromTextAlignment() falls through ASSERT_NOT_REACHED()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234989

            Bug ID: 234989
           Summary: WebKit::nsTextAlignmentFromTextAlignment() falls
                    through ASSERT_NOT_REACHED()
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: kkinnunen at apple.com,
                    webkit-bug-importer at group.apple.com
        Depends on: 234932

WebKit::nsTextAlignmentFromTextAlignment() falls through ASSERT_NOT_REACHED().

In the `default` case, `nsTextAlignment` is returned uninitialized.

static NSTextAlignment nsTextAlignmentFromTextAlignment(TextAlignment textAlignment)
{   
    NSTextAlignment nsTextAlignment;
    switch (textAlignment) {
    case NoAlignment:
        nsTextAlignment = NSTextAlignmentNatural;
        break;
    case LeftAlignment: 
        nsTextAlignment = NSTextAlignmentLeft;
        break;
    case RightAlignment:
        nsTextAlignment = NSTextAlignmentRight;
        break;
    case CenterAlignment: 
        nsTextAlignment = NSTextAlignmentCenter;
        break;
    case JustifiedAlignment:
        nsTextAlignment = NSTextAlignmentJustified;
        break;
    default:
        ASSERT_NOT_REACHED();
    }

    return nsTextAlignment;
}

See Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=234932
[Bug 234932] check-webkit-style: add checker for unexpected fall through after ASSERT_NOT_REACHED() statements
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220107/12eccc59/attachment.htm>