[Webkit-unassigned] [Bug 234975] New: WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234975

            Bug ID: 234975
           Summary: WebKit::DownloadProxy::publishProgress() falls through
                    ASSERT_NOT_REACHED()
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: achristensen at apple.com, kkinnunen at apple.com,
                    webkit-bug-importer at group.apple.com
        Depends on: 234932

WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED().

There should be an early return in the `else` block after ASSERT_NOT_REACHED().

#if PLATFORM(COCOA)
void DownloadProxy::publishProgress(const URL& URL)
{
    if (!m_dataStore)
        return;

    SandboxExtension::Handle handle;
    if (auto createdHandle = SandboxExtension::createHandle(URL.fileSystemPath(), SandboxExtension::Type::ReadWrite))
        handle = WTFMove(*createdHandle);
    else
        ASSERT_NOT_REACHED();

    m_dataStore->networkProcess().send(Messages::NetworkProcess::PublishDownloadProgress(m_downloadID, URL, handle), 0);
}
#endif // PLATFORM(COCOA)

See Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=234932
[Bug 234932] check-webkit-style: add checker for unexpected fall through after ASSERT_NOT_REACHED() statements
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220107/b093d7e4/attachment-0001.htm>