[Webkit-unassigned] [Bug 234965] New: Web Inspector: Inspector::RemoteInspector::receivedSetupMessage() falls through ASSERT_NOT_REACHED()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234965

            Bug ID: 234965
           Summary: Web Inspector:
                    Inspector::RemoteInspector::receivedSetupMessage()
                    falls through ASSERT_NOT_REACHED()
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: inspector-bugzilla-changes at group.apple.com,
                    webkit-bug-importer at group.apple.com
        Depends on: 234932

Inspector::RemoteInspector::receivedSetupMessage() falls through ASSERT_NOT_REACHED().

Since there are many other early returns in this method, it seems like there should be an early return after ASSERT_NOT_REACHED() as well.

void RemoteInspector::receivedSetupMessage(NSDictionary *userInfo)
{
    [...]
    if (is<RemoteInspectionTarget>(target)) {
        bool isAutomaticInspection = m_automaticInspectionCandidateTargetIdentifier == target->targetIdentifier();

        if (!connectionToTarget->setup(isAutomaticInspection, automaticallyPause)) {
            connectionToTarget->close();
            return;
        }
        m_targetConnectionMap.set(targetIdentifier, WTFMove(connectionToTarget));
    } else if (is<RemoteAutomationTarget>(target)) {
        if (!connectionToTarget->setup()) {
            connectionToTarget->close();
            return;
        }
        m_targetConnectionMap.set(targetIdentifier, WTFMove(connectionToTarget));
    } else
        ASSERT_NOT_REACHED();

    updateHasActiveDebugSession();
}

See Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=234932
[Bug 234932] check-webkit-style: add checker for unexpected fall through after ASSERT_NOT_REACHED() statements
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220107/bcff329f/attachment.htm>